Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: override external URL for additional registration #3935

Merged
merged 16 commits into from
Jan 14, 2025

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented Dec 16, 2024

Description

Allow users to define URL for additional registration when HA hostname is inaccessible.

Type of change

  • feat: New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

@achmelo achmelo closed this Dec 16, 2024
@achmelo achmelo reopened this Dec 16, 2024
@achmelo achmelo marked this pull request as draft December 16, 2024 13:42
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 16, 2024
@pablocarle pablocarle marked this pull request as ready for review January 3, 2025 15:12
@achmelo achmelo changed the title feat: override external URL for additional registration [DO NOT MERGE] feat: override external URL for additional registration Jan 7, 2025
@pj892031 pj892031 requested a review from pablocarle January 14, 2025 11:24
@pj892031 pj892031 changed the title [DO NOT MERGE] feat: override external URL for additional registration feat: override external URL for additional registration Jan 14, 2025
@pj892031 pj892031 merged commit d5dd912 into v3.x.x Jan 14, 2025
29 checks passed
@pj892031 pj892031 deleted the reboot/k8-routing branch January 14, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants